Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add RetainExceptOnCreate to ParseDeletionPolicy method #26880

Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix(core): add RetainExceptOnCreate to ParseDeletionPolicy method #26880

merged 2 commits into from
Aug 25, 2023

Conversation

dineshkatamneni
Copy link
Contributor

Describe the reason for this change, what the solution is, and any

CFN recently added support for a new deletion policy called RetainExceptOnCreate. This policy was added to the removal-policy enum in e0d5ca, however it is missing from the switch/case block in parseDeletionPolicy, which causes errors when this removal policy is used.

Closes #26863.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Aug 25, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 25, 2023 01:03
aws-cdk-automation
aws-cdk-automation previously requested changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@dineshkatamneni dineshkatamneni changed the title Add RetainExceptOnCreate to ParseDeletionPolicy method Fix: Add RetainExceptOnCreate to ParseDeletionPolicy method Aug 25, 2023
@dineshkatamneni dineshkatamneni changed the title Fix: Add RetainExceptOnCreate to ParseDeletionPolicy method fix: Add RetainExceptOnCreate to ParseDeletionPolicy method Aug 25, 2023
@dineshkatamneni dineshkatamneni changed the title fix: Add RetainExceptOnCreate to ParseDeletionPolicy method fix(aws-cdk-lib): Add RetainExceptOnCreate to ParseDeletionPolicy method Aug 25, 2023
@dineshkatamneni
Copy link
Contributor Author

Exemption Request: it's a small change, and the function doesn't have any test cases before.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Aug 25, 2023
@rix0rrr rix0rrr added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Aug 25, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 25, 2023 05:53

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain mrgrain changed the title fix(aws-cdk-lib): Add RetainExceptOnCreate to ParseDeletionPolicy method fix(aws-cdk-lib): add RetainExceptOnCreate to ParseDeletionPolicy method Aug 25, 2023
@mrgrain mrgrain changed the title fix(aws-cdk-lib): add RetainExceptOnCreate to ParseDeletionPolicy method fix(core): add RetainExceptOnCreate to ParseDeletionPolicy method Aug 25, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4df3a14
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 702d9d5 into aws:main Aug 25, 2023
16 checks passed
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cfn-parse.ts: parseDeletionPolicy is missing CreateExceptOnDelete
3 participants
@dineshkatamneni @aws-cdk-automation @rix0rrr